Difference between revisions of "Volt TODOs"

From comma wiki
Jump to: navigation, search
(Add cabana link for BCM fault)
Line 5: Line 5:
 
* Car won't resume from stop on a moderate uphill. Probably need to allow more gas otherwise hill assist won't release.
 
* Car won't resume from stop on a moderate uphill. Probably need to allow more gas otherwise hill assist won't release.
 
* canpacker is used to pack the most important messages in gmcan.py (steer, gas, brake). Use canpacker on all other messages too.
 
* canpacker is used to pack the most important messages in gmcan.py (steer, gas, brake). Use canpacker on all other messages too.
* Brake control module can fault and not respond to brake commands. It should be reproducible when killing manager while in standstill with ACC on (EPB will engage). Need to find the fault bit on PT-CAN and disallow openpilot engagements when present.
+
* Brake control module can fault and not respond to brake commands. It should be reproducible when killing manager while in standstill with ACC on (EPB will engage). Need to find the fault bit on PT-CAN and disallow openpilot engagements when present. (Cabana link where this happens t~=145 https://community.comma.ai/cabana/?route=f89c604cf653e2bf%7C2018-07-19--07-18-07&max=3&url=https%3A%2F%2Fchffrprivate.blob.core.windows.net%2Fchffrprivate3%2Fv2%2Ff89c604cf653e2bf%2F0f47ac5cd1c7d3274b394746f0e9d203_2018-07-19--07-18-07 )

Revision as of 15:40, 19 July 2018

comma will upstream the official Volt support on 06/16/2018. Some more polishing left to do.

  • radar_interface needs a bit that determines when a track is new to avoid data "jumps" when the same track ID switches from an object to another. Not so important, as objects seem to move to next available ID slot so the "jump" event should be rare.
  • Currently you can only engage > 15 mph, otherwise the gas won't respond. However, resume button seem to work sometime, even < 15mph. Find a way to reliably engage < 15mph.
  • Car won't resume from stop on a moderate uphill. Probably need to allow more gas otherwise hill assist won't release.
  • canpacker is used to pack the most important messages in gmcan.py (steer, gas, brake). Use canpacker on all other messages too.
  • Brake control module can fault and not respond to brake commands. It should be reproducible when killing manager while in standstill with ACC on (EPB will engage). Need to find the fault bit on PT-CAN and disallow openpilot engagements when present. (Cabana link where this happens t~=145 https://community.comma.ai/cabana/?route=f89c604cf653e2bf%7C2018-07-19--07-18-07&max=3&url=https%3A%2F%2Fchffrprivate.blob.core.windows.net%2Fchffrprivate3%2Fv2%2Ff89c604cf653e2bf%2F0f47ac5cd1c7d3274b394746f0e9d203_2018-07-19--07-18-07 )