Difference between revisions of "Volt TODOs"

From comma wiki
Jump to: navigation, search
(Add cabana for failed gas engage)
(3 intermediate revisions by 2 users not shown)
Line 1: Line 1:
Considering people are using it and the code is upstream quality, we have already paid out the bounty. But before we include it in openpilot releases, there's still a little polishing work to do.
comma will upstream the official Volt support on 06/16/2018. Some more polishing left to do.
* radar_interface needs a bit that determines when a track is new to avoid data "jumps" when the same track ID switches from an object to another. Not so important, as objects seem to move to next available ID slot so the "jump" event should be rare.
* <s>When the driver overrides openpilot steering, a safety mechanism must be present to limit how much torque is produced against the driver's will and to smooth the dynamic response right after the driver releases the steering wheel. Failing to implement such limitation is against the 2nd comma's safety principle: "... The vehicle must not alter its trajectory too quickly for the driver to safely react. This means that while the system is engaged, the actuators are constrained to operate within reasonable limits...". See comma's [https://github.com/commaai/one/blob/master/SAFETY.md safety principles]. See how this was implemented for the [https://github.com/commaai/panda/blob/master/board/safety/safety_cadillac.h Cadillac port]. </s>
* Currently you can only engage > 15 mph, otherwise the gas won't respond. However, resume button seem to work sometime, even < 15mph. Find a way to reliably engage < 15mph. (Cabana link where failed engagement happens https://community.comma.ai/cabana/?route=f89c604cf653e2bf%7C2018-07-28--15-28-19&max=18&url=https%3A%2F%2Fchffrprivate.blob.core.windows.net%2Fchffrprivate3%2Fv2%2Ff89c604cf653e2bf%2Fba5f372399ac0a3ccd1e40112332cea1_2018-07-28--15-28-19 t=230, followed by a successful engage w/ gas)
* Car won't resume from stop on a moderate uphill. Probably need to allow more gas otherwise hill assist won't release.
'''Convenience bugs'''
* canpacker is used to pack the most important messages in gmcan.py (steer, gas, brake). Use canpacker on all other messages too.
* <s>Soft disengagement when traction control is off</s>
* Brake control module can fault and not respond to brake commands. It should be reproducible when killing manager while in standstill with ACC on (EPB will engage). Need to find the fault bit on PT-CAN and disallow openpilot engagements when present. (Cabana link where this happens t~=145 https://community.comma.ai/cabana/?route=f89c604cf653e2bf%7C2018-07-19--07-18-07&max=3&url=https%3A%2F%2Fchffrprivate.blob.core.windows.net%2Fchffrprivate3%2Fv2%2Ff89c604cf653e2bf%2F0f47ac5cd1c7d3274b394746f0e9d203_2018-07-19--07-18-07 )
* <s>implement steer torque rate limiter in car controller to prevent control instability at low speed (part of safety as well).</s>
* <s>Done. See [https://github.com/vntarasov/openpilot/pull/2 PR] ''it happens that lateral control stops responding for long time and no alerts are sent out while openpilot is engaged. An alert must be shown and openpilot must disengage.'' </s>
* <s>Done. See [https://github.com/vntarasov/openpilot/pull/2 PR] ''Understand how to prevent/recover lateral faults (maybe commanding zero steer torque torque while certain CAN flags are set by the electronic power steering module?) ''</s>
* <s>when brake is pressed and user tries to engage, a "brake pressed" alert should be sent instead of the "no close lead" one.</s>
* <s>Done. See [https://github.com/commaai/panda/commit/293fd1ac70250a09b511cc8af99aa7f260d586ef commit] Improve the ignition logic to not be based on the gear value, so the EON transmits CAN messages also when the gear is P.</s>
* <s>Do not allow to engage when the the cruise main button is off, as the car won't respond to openpilot commands.</s>
* when car reaches a full stop while in openpilot, an alert should display the need to press the resume button to restart.
* radar_interface needs a bit that determines when a track is new (low priority, objects seem to move to next available slot)
* <s>add a no entry condition when when trying to set < 15mph </s>
* find a reliable way to be able to engage < 15mph and have gas responding
* <s>linearize the longitudinal control by clearily separating the non-linearities outside PID </s>
* use canpacker in gmcan
* <s>tune long control. it underbrakes </s>
* <s>fix overbraking < 1m/s </s>
* <s>fix boardd ignition logic (patched by using voltage monitor)</s>
* <s>disengage on park brake applied (560, bit 12)</s>

Latest revision as of 02:19, 29 July 2018

comma will upstream the official Volt support on 06/16/2018. Some more polishing left to do.